Skip to content

util/agents/usb_hid_relay: Fix agent errors #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cidlik wants to merge 1 commit into from
Closed

util/agents/usb_hid_relay: Fix agent errors #1776

cidlik wants to merge 1 commit into from
+5 −1

Conversation

@cidlik
Copy link
Contributor

@cidlik cidlik commented Nov 20, 2025 •
edited by Emantor
Loading

Description

TL;DR

  • get_output() should return some result;
  • should attach kernel driver back in the destructor otherwise HIDRAW device will not appear if it has existed.

Hello there! I have a USB HID relay and tests for it and I face with the issue when after labgrid using the relay will not display in /dev system. Only replugging helps to fix it.

I notice that the device attachment is not performed at the USBHIDRelay destructor, and it seems to me ambiguous because the device doesn't return to the initial state.

I ran multiple pytest processes to test concurrent situations which were fixed in 1526. Tests are passed.

Checklist

  • PR has been tested

@codecov
Copy link

codecov bot commented Nov 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.2%. Comparing base (c609d2d) to head (980a992).
⚠️ Report is 242 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/util/agents/usb_hid_relay.py 0.0% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c609d2d) and HEAD (980a992). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (c609d2d) HEAD (980a992)
3.11 4 1
3.10 4 1
3.9 4 1
3.13 4 1
3.12 4 1
Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #1776      +/-   ##
=========================================
- Coverage    56.0%   45.2%   -10.9%     
=========================================
  Files         170     172       +2     
  Lines       13307   13572     +265     
=========================================
- Hits         7458    6136    -1322     
- Misses       5849    7436    +1587
Flag Coverage Δ
3.10 45.2% <0.0%> (-11.2%) ⬇️
3.11 45.2% <0.0%> (-11.2%) ⬇️
3.12 45.2% <0.0%> (-11.2%) ⬇️
3.13 45.1% <0.0%> (-11.2%) ⬇️
3.14 45.1% <0.0%> (?)
3.9 45.2% <0.0%> (-11.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Emantor Emantor force-pushed the usb_hid_relay_issue branch from e5b5425 to 423b8c2 Compare November 21, 2025 10:50
Emantor
Emantor reviewed Nov 21, 2025
View reviewed changes
@cidlik
util/agents/usb_hid_relay: Fix agent errors
980a992 
* get_output() should return some result;
* should attach kernel driver back in the destructor otherwise HIDRAW
  device will not appear if it has existed.

Signed-off-by: Roman Kuznecov <zubastikiko@gmail.com>
@cidlik cidlik force-pushed the usb_hid_relay_issue branch from 423b8c2 to 980a992 Compare November 21, 2025 18:13
@cidlik
Copy link
Contributor Author

cidlik commented Nov 25, 2025

Hello there! @jluebbe, can you review the change, please?

@cidlik
Copy link
Contributor Author

cidlik commented Dec 8, 2025 •
edited
Loading

I tested the change with the next libusb versions:

$ dnf list installed | grep libusb
libusb.x86_64             1:0.1.5-12.el8                    @baseos                                       
libusb-devel.x86_64       1:0.1.5-12.el8                    @Stream-PowerTools                            
libusbmuxd.x86_64         1.0.10-9.el8                      @AppStream                                    
libusbx.i686              1.0.23-4.el8                      @baseos                                       
libusbx.x86_64            1.0.23-4.el8                      @anaconda                                     
libusbx-devel.x86_64      1.0.23-4.el8                      @baseos

ant it's ok. But it was found that with

# dnf list installed | grep libusb
libusb.x86_64                        1:0.1.7-5.el9                    @appstream
libusbx.x86_64                       1.0.26-1.el9                     @System   
libusbx-devel.x86_64                 1.0.26-1.el9                     @appstream

the messages are appeared in dmesg:

[4938041.201923] python3[3805345]: segfault at 111 ip 0000000000000111 sp 00007ffc8c54bba8 error 14 in python3.9[55820c756000+1000]
[4938041.201933] Code: Unable to access opcode bytes at RIP 0xe7.

It looks like the change may cause unexpected issue for someone else.

I close the PR until I can cope with the issue.

@cidlik cidlik closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Emantor Emantor Emantor approved these changes

Assignees

@jluebbe jluebbe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cidlik @Emantor @jluebbe